Editor hygiene + remove redundant idle-position clamp in predictions

- rotatingMachine.html: add default name:{value:""} to the editor
  defaults block (standard Node-RED pattern; was missing).
- nodeClass.js: clear node status badge on close — matches the
  pattern already in other EVOLV node close handlers.
- specificClass.js: remove the `(x <= 0) ? 0 : ...` guard in the
  flow and power prediction methods. The guard was redundant:
  predictions only run while the FSM is in an active state
  (operational / starting / warmingup / accelerating / decelerating),
  none of which produce x=0. Math.max(0, rawFlow) still clamps
  negative extrapolation. Net: same behaviour in production, less
  dead code.

All 10 basic tests pass.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
znetsixe
2026-04-22 17:50:50 +02:00
parent 11d196f363
commit 399e0a8c01
3 changed files with 4 additions and 3 deletions

View File

@@ -17,6 +17,7 @@
category: "EVOLV",
color: "#86bbdd",
defaults: {
name: { value: "" },
// Define specific properties
speed: { value: 1, required: true },

View File

@@ -405,6 +405,7 @@ class nodeClass {
clearTimeout(this._startupTimeout);
clearInterval(this._tickInterval);
clearInterval(this._statusInterval);
this.node.status({}); // clear node status badge
// Clean up child measurement listeners
const m = this.source;

View File

@@ -968,8 +968,7 @@ _callMeasurementHandler(measurementType, value, position, context) {
}
const rawFlow = this.predictFlow.y(x);
// Clamp: at position ≤ 0 the pump isn't rotating — physical flow is 0.
const cFlow = (x <= 0) ? 0 : Math.max(0, rawFlow);
const cFlow = Math.max(0, rawFlow);
this.measurements.type("flow").variant("predicted").position("downstream").value(cFlow,Date.now(),this.unitPolicy.canonical.flow);
this.measurements.type("flow").variant("predicted").position("atEquipment").value(cFlow,Date.now(),this.unitPolicy.canonical.flow);
return cFlow;
@@ -993,7 +992,7 @@ _callMeasurementHandler(measurementType, value, position, context) {
}
const rawPower = this.predictPower.y(x);
const cPower = (x <= 0) ? 0 : Math.max(0, rawPower);
const cPower = Math.max(0, rawPower);
this.measurements.type("power").variant("predicted").position('atEquipment').value(cPower, Date.now(), this.unitPolicy.canonical.power);
return cPower;
}