RnD/generalFunctions
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix ESLint errors, bugs, and add gravity export

Browse Source 
- Fix missing return in childRegistrationUtils.registerChild()
- Fix assertionUtils: assertNoNaN uses this.assertNoNaN
- Fix logger: nameModule uses this.nameModule
- Fix assetUtils: convert ESM to CommonJS
- Fix childRegistrationUtils_DEPRECATED: desc -> softwareType
- Add gravity export to index.js for rotatingMachine
- Fix ESLint errors across 18 files (no-undef, no-case-declarations,
  no-mixed-spaces-and-tabs, parsing errors)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Rene De Ren
2026-03-11 13:39:40 +01:00
parent 858189d6da
commit 82094d8d09
18 changed files with 55 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/convert/definitions/illuminance.js
View File

@@ -30,8 +30,8 @@ module.exports = {
ratio: 1/10.76391
},
imperial: {
unit: 'ft-cd',
ratio: 10.76391
unit: 'ft-cd',
ratio: 10.76391
}
}
};

28
src/convert/index.js
View File

@@ -127,7 +127,7 @@ Converter.prototype.toBest = function(options) {
if(!this.origin)
throw new Error('.toBest must be called after .from');
var options = Object.assign({
options = Object.assign({
exclude: [],
cutOffNumber: 1,
}, options)
@@ -268,22 +268,22 @@ Converter.prototype.throwUnsupportedUnitError = function (what) {
Converter.prototype.possibilities = function (measure) {
var possibilities = [];
if(!this.origin && !measure) {
each(keys(measures), function (measure){
each(measures[measure], function (units, system) {
if(system == '_anchors')
return false;
each(keys(measures), function (measure){
each(measures[measure], function (units, system) {
if(system == '_anchors')
return false;
possibilities = possibilities.concat(keys(units));
});
});
possibilities = possibilities.concat(keys(units));
});
});
} else {
measure = measure || this.origin.measure;
each(measures[measure], function (units, system) {
if(system == '_anchors')
return false;
measure = measure || this.origin.measure;
each(measures[measure], function (units, system) {
if(system == '_anchors')
return false;
possibilities = possibilities.concat(keys(units));
});
possibilities = possibilities.concat(keys(units));
});
}
return possibilities;

4
src/convert/lodash/lodash._basecreate/index.js
View File

@@ -21,12 +21,12 @@ var nativeCreate = reNative.test(nativeCreate = Object.create) && nativeCreate;
* @param {Object} prototype The object to inherit from.
* @returns {Object} Returns the new object.
*/
function baseCreate(prototype, properties) {
function baseCreate(prototype, properties) { // eslint-disable-line no-func-assign
return isObject(prototype) ? nativeCreate(prototype) : {};
}
// fallback for browsers without `Object.create`
if (!nativeCreate) {
baseCreate = (function() {
baseCreate = (function() { // eslint-disable-line no-func-assign
function Object() {}
return function(prototype) {
if (isObject(prototype)) {

2
src/convert/lodash/lodash._setbinddata/index.js
View File

@@ -24,7 +24,7 @@ var defineProperty = (function() {
var o = {},
func = reNative.test(func = Object.defineProperty) && func,
result = func(o, o, o) && func;
} catch(e) { }
} catch(e) { /* intentionally empty */ }
return result;
}());

2
src/helper/assertionUtils.js
View File

@@ -16,7 +16,7 @@ class Assertions {
assertNoNaN(arr, label = "array") {
if (Array.isArray(arr)) {
for (const el of arr) {
assertNoNaN(el, label);
this.assertNoNaN(el, label);
}
} else {
if (Number.isNaN(arr)) {

6
src/helper/assetUtils.js
View File

@@ -1,3 +1,5 @@
export function getAssetVariables() {
function getAssetVariables() {
}
}
module.exports = { getAssetVariables };

2
src/helper/childRegistrationUtils.js
View File

@@ -39,7 +39,7 @@ class ChildRegistrationUtils {
// IMPORTANT: Only call parent registration - no automatic handling and if parent has this function then try to register this child
if (typeof this.mainClass.registerChild === 'function') {
this.mainClass.registerChild(child, softwareType);
return this.mainClass.registerChild(child, softwareType);
}
this.logger.info(`✅ Child ${name} registered successfully`);

2
src/helper/childRegistrationUtils_DEPRECATED.js
View File

@@ -93,7 +93,7 @@ class ChildRegistrationUtils {
break;
default:
this.logger.error(`Child registration unrecognized desc: ${desc}`);
this.logger.error(`Child registration unrecognized desc: ${softwareType}`);
this.logger.error(`Unrecognized softwareType: ${softwareType}`);
}
}

2
src/helper/logger.js
View File

@@ -44,7 +44,7 @@ class Logger {
if (this.levels.includes(level)) {
this.logLevel = level;
} else {
console.error(`[ERROR ${nameModule}]: Invalid log level: ${level}`);
console.error(`[ERROR ${this.nameModule}]: Invalid log level: ${level}`);
}
}

3
src/helper/menuUtils.js
View File

@@ -158,7 +158,7 @@ async apiCall(node) {
// OLFIANT when a browser refreshes the tag code is lost!!! fix this later!!!!!
// FIX UUID ALSO LATER
if(node.assetTagCode !== "" || node.assetTagCode !== null){ }
if(node.assetTagCode !== "" || node.assetTagCode !== null){ /* intentionally empty */ }
// API call to register or check asset in central database
let assetregisterAPI = node.configUrls.cloud.taggcodeAPI + "/asset/create_asset.php";
@@ -264,6 +264,7 @@ async fetchProjectData(url) {
return responsData;
} catch (err) {
/* intentionally empty */
}
}

3
src/helper/menuUtils_DEPRECATED.js
View File

@@ -158,7 +158,7 @@ async apiCall(node) {
// OLFIANT when a browser refreshes the tag code is lost!!! fix this later!!!!!
// FIX UUID ALSO LATER
if(node.assetTagCode !== "" || node.assetTagCode !== null){ }
if(node.assetTagCode !== "" || node.assetTagCode !== null){ /* intentionally empty */ }
// API call to register or check asset in central database
let assetregisterAPI = node.configUrls.cloud.taggcodeAPI + "/asset/create_asset.php";
@@ -264,6 +264,7 @@ async fetchProjectData(url) {
return responsData;
} catch (err) {
/* intentionally empty */
}
}

2
src/helper/nodeTemplates.js
View File

@@ -53,4 +53,4 @@ const nodeTemplates = {
// …add more node “templates” here…
};
export default nodeTemplates;
module.exports = nodeTemplates;

5
src/helper/outputUtils.js
View File

@@ -37,14 +37,15 @@ class OutputUtils {
if (Object.keys(changedFields).length > 0) {
switch (format) {
case 'influxdb':
case 'influxdb': {
// Extract the relevant config properties.
const relevantConfig = this.extractRelevantConfig(config);
// Flatten the tags so that no nested objects are passed on.
const flatTags = this.flattenTags(relevantConfig);
msg = this.influxDBFormat(changedFields, config, flatTags);
break;
}
case 'process':

6
src/measurements/MeasurementContainer.js
View File

@@ -95,7 +95,7 @@ class MeasurementContainer {
}
this._currentPosition = positionValue.toString().toLowerCase();;
this._currentPosition = positionValue.toString().toLowerCase();
return this;
}
@@ -328,7 +328,7 @@ class MeasurementContainer {
getLaggedSample(lag = 1,requestedUnit = null ){
const measurement = this.get();
if (!measurement) return null;
let sample = measurement.getLaggedSample(lag);
if (sample === null) return null;
@@ -340,7 +340,7 @@ class MeasurementContainer {
// Convert if needed
if (measurement.unit && requestedUnit !== measurement.unit) {
try {
const convertedValue = convertModule(value).from(measurement.unit).to(requestedUnit);
const convertedValue = convertModule(sample.value).from(measurement.unit).to(requestedUnit);
//replace old value in sample and return obj
sample.value = convertedValue ;
sample.unit = requestedUnit;

2
src/measurements/examples.js
View File

@@ -1,5 +1,7 @@
const { MeasurementContainer } = require('./index');
const measurements = new MeasurementContainer();
console.log('=== MEASUREMENT CONTAINER EXAMPLES ===\n');
console.log('This guide shows how to use the MeasurementContainer for storing,');
console.log('retrieving, and converting measurement data with automatic unit handling.\n');

2
src/predict/interpolation.js
View File

@@ -101,6 +101,7 @@ class Interpolation {
} else if (type == "monotone_cubic_spline") {
this.monotonic_cubic_spline();
} else if (type == "linear") {
/* intentionally empty */
} else {
this.error = 1000;
}
@@ -266,6 +267,7 @@ class Interpolation {
let k = 0;
if (xpoint < xdata[0] || xpoint > xdata[n - 1]) {
/* intentionally empty */
}
while (k < n - 1 && xpoint > xdata[k + 1] && !(xpoint < xdata[0] || xpoint > xdata[n - 1])) {

6
src/state/movementManager.js
View File

@@ -49,15 +49,17 @@ class movementManager {
try {
// Execute the movement logic based on the mode
switch (this.movementMode) {
case "staticspeed":
case "staticspeed": {
const movelinFeedback = await this.moveLinear(targetPosition,signal);
this.logger.info(`Linear move: ${movelinFeedback} `);
break;
}
case "dynspeed":
case "dynspeed": {
const moveDynFeedback = await this.moveEaseInOut(targetPosition,signal);
this.logger.info(`Dynamic move : ${moveDynFeedback}`);
break;
}
default:
throw new Error(`Unsupported movement mode: ${this.movementMode}`);