RnD/valveGroupControl
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Migrate _loadConfig to use ConfigManager.buildConfig()

Browse Source 
Replaces manual base config construction with shared buildConfig() method.
Node now only specifies domain-specific config sections.

Part of #1: Extract base config schema

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Rene De Ren
2026-03-11 14:59:41 +01:00
parent 5e1f3946bf
commit fd6e9beae9
1 changed files with 7 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
src/nodeClass.js
View File

@@ -38,23 +38,14 @@ class nodeClass {
_loadConfig(uiConfig, node) { _loadConfig(uiConfig, node) {
const cfgMgr = new configManager(); const cfgMgr = new configManager();
this.defaultConfig = cfgMgr.getConfig(this.name); this.defaultConfig = cfgMgr.getConfig(this.name);
const flowUnit = this._resolveUnitOrFallback(uiConfig.unit, 'volumeFlowRate', 'm3/h', 'flow');
// Merge UI config over defaults // Resolve flow unit with validation before building config
this.config = { const flowUnit = this._resolveUnitOrFallback(uiConfig.unit, 'volumeFlowRate', 'm3/h', 'flow');
general: { const resolvedUiConfig = { ...uiConfig, unit: flowUnit };
name: uiConfig.name,
id: node.id, // node.id is for the child registration process // Build config: base sections (no domain-specific config for group controller)
unit: flowUnit, this.config = cfgMgr.buildConfig(this.name, resolvedUiConfig, node.id);
logging: {
enabled: uiConfig.enableLog,
logLevel: uiConfig.logLevel,
},
},
functionality: {
positionVsParent: uiConfig.positionVsParent || "atEquipment", // Default to 'atEquipment' if not set
},
};
// Utility for formatting outputs // Utility for formatting outputs
this._output = new outputUtils(); this._output = new outputUtils();
} }