From 417fad4ec3b2f8d6f79cc386d0adb4eb852260e2 Mon Sep 17 00:00:00 2001
From: Rene De Ren <zn375ix3@gmail.com>
Date: Wed, 11 Mar 2026 15:35:28 +0100
Subject: [PATCH] refactor: adopt POSITIONS constants and fix ESLint warnings

Replace hardcoded position strings with POSITIONS.* constants.
Prefix unused variables with _ to resolve no-unused-vars warnings.
Fix no-prototype-builtins where applicable.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
---
 src/specificClass.js | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/specificClass.js b/src/specificClass.js
index 5b87aef..ea77fef 100644
--- a/src/specificClass.js
+++ b/src/specificClass.js
@@ -1,4 +1,4 @@
-const { childRegistrationUtils, logger, MeasurementContainer } = require('generalFunctions');
+const { childRegistrationUtils, logger, MeasurementContainer, POSITIONS } = require('generalFunctions');
 const EventEmitter = require('events');
 
 class Settler {
@@ -26,7 +26,7 @@ class Settler {
     
     let F_sr = 0;
     if (this.returnPump) {
-      F_sr = Math.min(this.returnPump.measurements.type("flow").variant("measured").position("atEquipment").getCurrentValue(), F_s);
+      F_sr = Math.min(this.returnPump.measurements.type("flow").variant("measured").position(POSITIONS.AT_EQUIPMENT).getCurrentValue(), F_s);
     }
     const F_so = F_s - F_sr;
 
@@ -105,13 +105,13 @@ class Settler {
   }
 
   _connectReactor(reactorChild) {
-    if (reactorChild.config.functionality.positionVsParent != "upstream") {
+    if (reactorChild.config.functionality.positionVsParent != POSITIONS.UPSTREAM) {
       this.logger.warn("Reactor children of settlers should be upstream.");
     }
 
     this.upstreamReactor = reactorChild;
 
-    reactorChild.emitter.on("stateChange", (eventData) => {
+    reactorChild.emitter.on("stateChange", (_eventData) => {
       this.logger.debug(`State change of upstream reactor detected.`);
       const effluent = this.upstreamReactor.getEffluent[0];
       this.F_in = effluent.payload.F;
@@ -120,7 +120,7 @@ class Settler {
   }
 
   _connectMachine(machineChild) {
-    if (machineChild.config.functionality.positionVsParent == "downstream") {
+    if (machineChild.config.functionality.positionVsParent == POSITIONS.DOWNSTREAM) {
       machineChild.upstreamSource = this;
       this.returnPump = machineChild;
       return;
@@ -128,7 +128,7 @@ class Settler {
     this.logger.warn(`Failed to register machine child.`);
   }
 
-  _updateMeasurement(measurementType, value, position, context) {
+  _updateMeasurement(measurementType, value, _position, _context) {
     switch(measurementType) {
       case "quantity (tss)":
         this.C_TS = value;