Files

znetsixe 17b88870bb fix: interruptible shutdown/emergencystop + dual-curve test coverage

Runtime:
- executeSequence now normalizes sequenceName to lowercase so parent
  orchestrators that use 'emergencyStop' (capital S) route correctly to
  the 'emergencystop' sequence key. Closes the "Sequence 'emergencyStop'
  not defined" warn seen when commands reach the node during accelerating.
- When a shutdown or emergencystop sequence is requested while the FSM is
  in accelerating/decelerating, the active movement is aborted via
  state.abortCurrentMovement() and the sequence waits (up to 2s) for the
  FSM to return to 'operational' before proceeding. New helper
  _waitForOperational listens on the state emitter for the transition.
- Single-side pressure warning: fix "acurate" typo and make the message
  actionable.

Tests (+15, now 91/91 passing):
- test/integration/interruptible-movement.integration.test.js (+3):
  shutdown during accelerating -> idle; emergencystop during accelerating
  -> off; mixed-case sequence-name normalization.
- test/integration/curve-prediction.integration.test.js (+12):
  parametrized across both shipped pump curves (hidrostal-H05K-S03R and
  hidrostal-C5-D03R-SHN1). Verifies loader integrity, mid-range prediction
  sanity, flow monotonicity in ctrl, inverse-pressure monotonicity, CoG
  finiteness, and reverse-predictor round-trip.

E2E:
- test/e2e/curve-prediction-benchmark.py: live Dockerized Node-RED
  benchmark that deploys one rotatingMachine per curve and runs a per-pump
  (pressure x ctrl) sweep inside each curve's envelope. Reports envelope
  compliance and monotonicity.
- test/e2e/README.md documents the benchmark and a known limitation:
  pressure below the curve's minimum slice extrapolates wildly
  (defended by upstream measurement-node clamping in production).

UX:
- rotatingMachine.html: added placeholders and descriptions for Reaction
  Speed / Startup / Warmup / Shutdown / Cooldown. Expanded the Node-RED
  help panel with a topic reference, port documentation, state diagram,
  and prediction rules.

Docs:
- README.md rewritten (was a single line) with install, quick start,
  topic/port reference, state machine, predictions, testing, production
  status.

Depends on generalFunctions commit 75d16c6 (state.js abort recovery and
rotatingMachine schema additions).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

2026-04-13 13:21:48 +02:00

2.4 KiB

Raw Blame History

rotatingMachine — End-to-End Benchmarks

These are live-deploy benchmarks, not unit tests. They require a running Docker-hosted Node-RED with the EVOLV package mounted, and they drive the node through its real runtime: admin-API deploy, debug websocket capture, inject-triggered commands, 1-second tick loop.

Unit tests live in ../basic/, ../integration/, ../edge/. Run those with npm test.

Prerequisites

cd /mnt/d/gitea/EVOLV
docker compose up -d nodered influxdb
# wait for http://localhost:1880/nodes to return 200
pip install --user --break-system-packages websocket-client requests

Benchmarks

`curve-prediction-benchmark.py`

Deploys one rotatingMachine per shipped pump curve (hidrostal-H05K-S03R, hidrostal-C5-D03R-SHN1) and runs a per-pump (pressure × ctrl) sweep. For each pump the sweep covers its own low / mid / high pressure slices with controller setpoints of 20 / 40 / 60 / 80 %.

Reports:

Count of samples inside the curve envelope ("good") vs out-of-range ("bad").
Monotonicity of flow across the ctrl sweep at fixed pressure.
Full sample table with state, ctrl, flow, power, NCog, cog.

python3 nodes/rotatingMachine/test/e2e/curve-prediction-benchmark.py
cat /tmp/rm_curve_bench.json

Expected output (green run, 2026-04-13)

Pump	Samples	Flow range	Power range	Pressures	Envelope OK	Monotonic
H05K	12	10.3–208.3 m³/h	12.3–50.3 kW	700–3900 mbar	✅	✅
C5	12	8.7–45.6 m³/h	0.69–13.0 kW	400–2900 mbar	✅	✅

Known limitation — out-of-envelope pressure extrapolation

Feeding a pressure below the curve's lowest slice produces extrapolated flow values that can exceed the envelope by orders of magnitude. Example: H05K at 400 mbar (curve min 700 mbar), ctrl=20% → flow ≈ 30 000 m³/h (envelope max 227 m³/h).

The node does not clamp pressure to the curve envelope; in production this is defended by upstream measurement nodes with realistic ranges. Operators deploying a machine should confirm the sensor range matches the curve.

`../../../../memory/` companion benchmarks

The earlier shutdown, interruptibility, and clean-path benchmarks (rm_e2e_benchmark.py, rm_clean.py, rm_e2e_verify.py) live in /tmp/ during a review session. Promote them into this directory when they need to become permanent smoke tests.

2.4 KiB Raw Blame History Unescape Escape