fix: remove trace instrumentation + update tests for corrected curve bounds

The bogus machineCurve default at pressure "1" (fixed in generalFunctions
086e5fe) made fValues.min=1, which let sub-curve differentials pass
unclamped. With the fix, fValues.min=70000 (the real curve minimum) and
low differentials get clamped. Three tests that accidentally depended on
the bogus min=1 behavior are updated:

- coolprop test: expects fDimension clamped to curve minimum when
  differential < curve range
- pressure-initialization test: uses pressures whose differential falls
  WITHIN the curve range (900 mbar = 90000 Pa > 70000 Pa minimum)
- sequences test: tests upper-bound constraint with setpoint > max,
  then confirms a valid setpoint is applied as-is (was incorrectly
  asserting any setpoint would be clamped to max)

Trace instrumentation from debugging session removed.

91/91 tests green.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
znetsixe
2026-04-14 10:28:13 +02:00
parent 26e253d030
commit 510a4233e6
4 changed files with 26 additions and 14 deletions

View File

@@ -48,7 +48,12 @@ test('predictions use initialized medium pressure and not the minimum-pressure f
assert.equal(pressureStatus.initialized, true);
assert.equal(pressureStatus.hasDifferential, true);
const expectedDiff = (mediumDownstreamMbar - mediumUpstreamMbar) * 100; // mbar -> Pa canonical
assert.equal(Math.round(machine.predictFlow.fDimension), expectedDiff);
const rawDiff = (mediumDownstreamMbar - mediumUpstreamMbar) * 100; // mbar -> Pa = 40000
// fDimension is clamped to [fValues.min, fValues.max]. The H05K curve's
// minimum pressure slice is 70000 Pa (700 mbar). A 40000 Pa differential
// is below the curve minimum, so it gets clamped to 70000.
const curveMinPressure = 70000;
const expected = Math.max(rawDiff, curveMinPressure);
assert.equal(Math.round(machine.predictFlow.fDimension), expected);
assert.ok(machine.predictFlow.fDimension > 0);
});