From 4a9521154b9f5f4dce713c4d25c7c9967e3f82a2 Mon Sep 17 00:00:00 2001 From: znetsixe Date: Tue, 14 Apr 2026 14:11:08 +0200 Subject: [PATCH] fix: safety overfill keeps pumps running + minHeightBasedOn=inlet MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit pumpingStation 5e2ebe4: overfill safety no longer shuts down machine groups or blocks level control. Pumps keep running during overfill (sewer can't stop receiving). Only upstream equipment is shut down. Demo config: minHeightBasedOn=inlet (not outlet). The minimum height reference for the basin is the inlet pipe elevation — sewage flows in by gravity and the basin level can't go below the inlet without the sewer backing up. Co-Authored-By: Claude Opus 4.6 (1M context) --- examples/pumpingstation-3pumps-dashboard/build_flow.py | 2 +- examples/pumpingstation-3pumps-dashboard/flow.json | 2 +- nodes/pumpingStation | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/examples/pumpingstation-3pumps-dashboard/build_flow.py b/examples/pumpingstation-3pumps-dashboard/build_flow.py index 89dacaa..30bb542 100644 --- a/examples/pumpingstation-3pumps-dashboard/build_flow.py +++ b/examples/pumpingstation-3pumps-dashboard/build_flow.py @@ -598,7 +598,7 @@ def build_process_tab(): "maxFlowLevel": 3.5, # 100% pump demand at this level # Hydraulics "refHeight": "NAP", - "minHeightBasedOn": "outlet", + "minHeightBasedOn": "inlet", "basinBottomRef": 0, "staticHead": 12, "maxDischargeHead": 24, diff --git a/examples/pumpingstation-3pumps-dashboard/flow.json b/examples/pumpingstation-3pumps-dashboard/flow.json index 2f04d6b..fbdabe2 100644 --- a/examples/pumpingstation-3pumps-dashboard/flow.json +++ b/examples/pumpingstation-3pumps-dashboard/flow.json @@ -865,7 +865,7 @@ "minFlowLevel": 2.0, "maxFlowLevel": 3.5, "refHeight": "NAP", - "minHeightBasedOn": "outlet", + "minHeightBasedOn": "inlet", "basinBottomRef": 0, "staticHead": 12, "maxDischargeHead": 24, diff --git a/nodes/pumpingStation b/nodes/pumpingStation index e8dd657..5e2ebe4 160000 --- a/nodes/pumpingStation +++ b/nodes/pumpingStation @@ -1 +1 @@ -Subproject commit e8dd657b4fbff703c0649f10fa985e8f7a739a40 +Subproject commit 5e2ebe4d96d0b925a17007804815ed893916942f